-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Cupertino gallery app #2715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cupertino gallery app #2715
Conversation
@sethladd @MitchellGoodwin -- I'm adding a Cupertino gallery app to match the Material 3 Demo sample. This is also the sample I want to use to experiment with AI maintenance as Cupertino is updated with releases. Can you double check the list of widgets that are being shown and let me know if anything important is missing or anything should be removed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions. It might be a good idea to add something showing CupertinoSheetRoute as well.
child: Center( | ||
child: ListView( | ||
children: [ | ||
CupertinoListSection( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CupertinoListSection.insetGrouped
might be better to show. It became the default in SwiftUI since the CupertinoListSection class was created.
builder: (BuildContext context) => CupertinoAlertDialog( | ||
title: const Text('Alert'), | ||
content: const Text('This is a sample alert dialog.'), | ||
actions: <CupertinoDialogAction>[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to add another action with isDestructiveAction
set to true to show the different styling.
middle: Text('Switch'), | ||
), | ||
child: Center( | ||
child: CupertinoSwitch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are showing CupertinoSwitch, showing CupertinoRadio and Checkbox might be a good idea too.
Resolves #2519
Part of the larger effort to bring the samples/repo into a stable and maintainable condition that also remains useful. See: #2409
Pre-launch Checklist
///
).